Copilot commented on code in PR #3832: URL: https://github.com/apache/celeborn/pull/3832#discussion_r4003553447
########## service/src/main/scala/org/apache/celeborn/server/common/http/api/HealthResource.scala: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.server.common.http.api + +import javax.ws.rs.{GET, Path, Produces} +import javax.ws.rs.core.{MediaType, Response} + +import io.swagger.v3.oas.annotations.Operation +import io.swagger.v3.oas.annotations.media.{Content, Schema} +import io.swagger.v3.oas.annotations.responses.ApiResponse +import io.swagger.v3.oas.annotations.tags.Tag + +/** + * The response of the health check, see [[HealthResource]]. + * + * @param service the name of the service, either `master` or `worker`. + * @param healthy whether the service is able to serve. + * @param reason the reason why the service is not able to serve, empty when healthy. + */ +case class HealthCheckResponse(service: String, healthy: Boolean, reason: String) + +@Tag(name = "Health") +@Path("/healthz") Review Comment: The PR contract and examples require `GET /health`, but this resource is mounted at `/healthz`, so clients and probes using the documented `/health` URL receive 404. Please align the resource path with the requested endpoint and update the corresponding bypass path, tests, and documentation consistently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
