Kalvin2077 commented on code in PR #3828:
URL: https://github.com/apache/celeborn/pull/3828#discussion_r4005855888
##########
cli/src/main/scala/org/apache/celeborn/cli/worker/WorkerOptions.scala:
##########
@@ -61,6 +61,14 @@ final class WorkerOptions {
description = Array("Exit the application with a specified type"))
private[worker] var exitType: String = _
+ @Option(
+ names = Array("--exit-timeout"),
Review Comment:
**Keep the timeout option out of the mutually exclusive action group**
`WorkerOptions` is installed by
[WorkerSubcommand](https://github.com/apache/celeborn/blob/7e1824cc341f4bbf70a9336ef41c55adde00e88e/cli/src/main/scala/org/apache/celeborn/cli/worker/WorkerSubcommand.scala#L34-L35)
as `@ArgGroup(exclusive = true, multiplicity = "1")`. Adding `--exit-timeout`
here makes it mutually exclusive with `--exit`. Using the actual options class
and the same group declaration with picocli 4.7.6, `--exit DECOMMISSION
--exit-timeout 30m` returns code 2 with “--exit=exit_type,
--exit-timeout=duration are mutually exclusive”, before the command runs.
Consequently, the advertised CLI override cannot send a request. Move the
modifier outside the action-selection group, or introduce a non-exclusive exit
subgroup while retaining mutual exclusion between actions. Add a parsing
regression test for the documented combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
