yew1eb opened a new pull request, #3847: URL: https://github.com/apache/celeborn/pull/3847
### What changes were proposed in this pull request? 1. `Worker.decommissionWorker()`: skip the state transition when the worker is already in `InDecommission` state. 2. `ReadBufferDispatcher`: catch `InterruptedException` separately in the dispatcher loop — log as INFO when shutting down (`stopFlag=true`), WARN otherwise. ### Why are the changes needed? When a worker exits after decommission is triggered, the shutdown hook prints misleading logs that look like real errors: ``` WARN WorkerStatusManager: Worker transition status from InDecommission to InDecommission is not allowed. ERROR ReadBufferDispatcher: Read buffer dispatcher encountered error: null java.lang.InterruptedException ``` Both are harmless shutdown noise: 1. The worker is already in `InDecommission` state (set by the decommission event path via heartbeat response or REST `/exit?type=DECOMMISSION`) when the shutdown hook calls `decommissionWorker()`, and the state machine has no self-loop, so the repeated transition is rejected with a WARN. 2. `ReadBufferDispatcher.close()` sets `stopFlag=true` and interrupts the dispatcher thread blocked in `requests.poll()`; the `InterruptedException` falls into the generic `catch (Throwable)` and is logged as ERROR with a `null` message (`InterruptedException.getMessage()` returns null). ### Does this PR resolve a correctness bug? <!-- Check if yes. The `correctness` label will be added/removed automatically. --> - [ ] Yes ### Does this PR introduce _any_ user-facing change? <!-- Check if yes. --> - [ ] Yes ### How was this patch tested? Compiled the worker module: `build/mvn -pl worker -am -DskipTests compile`. Logging-only change, no behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
