Copilot commented on code in PR #3834:
URL: https://github.com/apache/celeborn/pull/3834#discussion_r4004602735
##########
client-spark/spark-3/src/test/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleManagerSuite.scala:
##########
@@ -92,6 +92,20 @@ class SparkShuffleManagerSuite extends Logging {
sc.stop()
}
+ @junit.Test
+ def testReliableStorageFollowsFallbackPolicy(): Unit = {
+ // supportsReliableStorage must be true only for NEVER; AUTO/ALWAYS may
fall back to local-disk
+ // shuffle, so reporting reliable storage would let DRA reclaim executors
holding fallback data.
+ def reliable(policy: String): Boolean = {
+ val conf = new SparkConf()
+ .set(s"spark.${CelebornConf.SPARK_SHUFFLE_FALLBACK_POLICY.key}",
policy)
+ new CelebornShuffleDataIO(conf).driver().supportsReliableStorage()
Review Comment:
This test does not compile against the Spark 3.0–3.4 profiles:
`ShuffleDriverComponents#supportsReliableStorage` is absent before Spark 3.5,
and `driver()` is statically typed as that interface. The `spark-3` module is
built for those older versions as well, so invoke this optional method
reflectively (or otherwise gate the test to Spark 3.5+) instead of calling it
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
