shlomitubul commented on code in PR #3845:
URL: https://github.com/apache/celeborn/pull/3845#discussion_r4012975957
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1279,6 +1289,12 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
}
}
+ if (celebornShuffleIdToAppShuffleIdMap.containsKey(shuffleId)) {
+ val appShuffleId = celebornShuffleIdToAppShuffleIdMap.get(shuffleId)
+ if (shuffleIdMapping.containsKey(appShuffleId) &&
registeredShuffle.contains(shuffleId)) {
+ expiredShuffleIds.add(shuffleId)
Review Comment:
that is right there is nothing to removes...entries are now only added when
a stage rerun releases a copy mid job, so the set has one Int per rerun and
stays empty for jobs that never rerun.(the remove in `unregisterAppShuffle` was
dropped because that path no longer adds anything, so it had nothing to remove)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
