gauravkm commented on PR #3858: URL: https://github.com/apache/celeborn/pull/3858#issuecomment-5824387430
CI has 11 failing checks that need investigation: Maven service on Java [8](https://github.com/apache/celeborn/actions/runs/35975631205/job/107555315238), [11](https://github.com/apache/celeborn/actions/runs/35975631205/job/107555315510), and [17](https://github.com/apache/celeborn/actions/runs/35975631205/job/107555315346); SBT service on Java 8 / Scala [2.12](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315146) and [2.13](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315381), Java 11 / Scala [2.12](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315454) and [2.13](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315373), Java 17 / Scala [2.12](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315189) and [2.13](https://github.com/apache/celeborn/actions/runs/35975631316/job/107555315368); [Spark 3.5 / Java 17 / LocalDiskShuffleDataIO](https://github.com/apache/celeborn /actions/runs/35975631205/job/107555315955); and [Flink 1.20 / Java 11](https://github.com/apache/celeborn/actions/runs/35975631205/job/107555315256). The SBT Java 11 / Scala 2.13 log reports unsuccessful celeborn-common tests. Looks good from my P0/P1 code review; no introduced P0/P1 issues found. I checked optional heartbeat serialization, default-disabled collection, collector lifecycle, reuse of memory/storage snapshots, and latest-snapshot retention and worker-loss cleanup. Added tests cover metric round-trips, basic collection, and store retention/removal; mixed-version heartbeats, window rollover, and collector failure handling remain uncovered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
