gauravkm commented on code in PR #3857:
URL: https://github.com/apache/celeborn/pull/3857#discussion_r4141242400
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -401,6 +406,58 @@ public void setClientId(String id) {
this.clientId = id;
}
+ /** Installs a connection-bound policy once, after the plugin has
authenticated its peer. */
+ public synchronized void setSecurityContext(ConnectionSecurityContext
context) {
+ Preconditions.checkNotNull(context, "securityContext");
+ Preconditions.checkState(securityContext == null, "Security context has
already been set.");
+ securityContext = context;
Review Comment:
CI still has the three Maven service failures linked in my [current
summary](https://github.com/apache/celeborn/pull/3857#issuecomment-5905045796).
I verified this P1 is fixed in `ef31bbb`: network dispatch preserves the
receiving connection, `Inbox` authorizes before both handlers, and Master’s
internal endpoint forwards the same context. Unregister now consults the
installed policy before mutation even with a null native client ID. The new
external/internal RPC denial tests exercise this boundary. Their unregister
matrix starts empty, so it does not specifically assert preservation of a
seeded victim shuffle; the dispatch ordering establishes the fix in source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
