RexXiong commented on code in PR #3860:
URL: https://github.com/apache/celeborn/pull/3860#discussion_r4214396781
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -679,6 +680,7 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
cleanDB: Boolean = true): Unit = {
expiredShuffleKeys.asScala.foreach { shuffleKey =>
logInfo(s"Cleanup expired shuffle $shuffleKey.")
+ committedFileInfos.remove(shuffleKey)
Review Comment:
Since committedFileInfos is now populated only when graceful shutdown is
enabled, moving this removal is unnecessary for fixing the reported leak.
It also introduces a race where a concurrent writer may complete after this
removal and reinsert the expired shuffle. Please keep the removal in its
original position and limit this fix to guarding notifyFileInfoCommitted() with
workerGracefulShutdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
