zaynt4606 commented on PR #3854: URL: https://github.com/apache/celeborn/pull/3854#issuecomment-6138038558
Thanks for addressing the earlier review feedback. 1. Please update this branch to the latest `main` and resolve the chart conflicts now that #3855 has landed. These affect the README, values, worker StatefulSet template and its tests. Please preserve the per-zone StatefulSets, autoscaling and drain support, and rerun the Helm chart checks after resolving the conflicts. 2. **Non-blocking:** please update the PR description to match the current implementation. The probe-default table, the statements about enabled master/worker probes, and the user-facing change section still describe the old defaults. All probes are now opt-in; the description should also reflect that both startup and readiness probes require `Parallel` when there is more than one master. The failing Flink shuffle-counter test appears unrelated to these Helm chart changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
