yew1eb commented on PR #3880: URL: https://github.com/apache/celeborn/pull/3880#issuecomment-6267620871
Thanks for the review! Addressed in 0e286a6cd: - **OS/arch in key**: added `runner.os` to both the cache key and the restore key prefix, so the cache can never be reused across runner platforms. - **pom.xml as the key source**: kept intentionally — `pom.xml` is where `<maven.version>` is defined and where `build/mvn` reads it from, so a Maven version bump invalidates the exact key. Unrelated pom changes fall back to the restore key prefix, and since the restored cache already contains `build/apache-maven-<version>/`, `build/mvn` skips the download, so there is no re-download cost. - **Duplication across jobs**: kept the steps inlined for readability; happy to factor them into a composite action as a follow-up if reviewers prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
