Kalvin2077 commented on code in PR #3858: URL: https://github.com/apache/celeborn/pull/3858#discussion_r4451498779
########## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/metrics/ScaleMetricCollector.scala: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.service.deploy.worker.metrics + +import org.apache.celeborn.common.metrics.WorkerStats +import org.apache.celeborn.service.deploy.worker.Worker + +trait ScaleMetricCollector { + def init(worker: Worker): Unit Review Comment: Replaced the `Worker` parameter with a public `ScaleMetricCollectorContext` exposing read-only observations. Its constructor is restricted to the worker package, while external collectors can access its public methods. Moved the integration test collector to `com.example.metrics` to verify that an external implementation can compile and initialize through the configured collector class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
