[
https://issues.apache.org/jira/browse/CLOUDSTACK-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609802#comment-13609802
]
Murali Reddy commented on CLOUDSTACK-1664:
------------------------------------------
snip from the dev list thread
On 21/03/13 6:20 AM, "Murali Reddy" <murali.re...@citrix.com> wrote:
As I mentioned, this is case with particular actions only. For e.g please
check crete user generates event?
On 21/03/13 4:01 AM, "Sangeetha Hariharan"
<sangeetha.hariha...@citrix.com> wrote:
Murali,
Fix for CLOUDSTACK-1664 has not made it to 4.1 yet.
Using builds from master , I am able to see the events being generated
when creating account and for many other activities like starting Vms ,
creating firewall rules:
| 94 | 7683e89f-2dc8-46a8-bb8e-4acf0c0bff53 | ACCOUNT.CREATE |
Completed | Successfully completed creating Account. Account Name:
sangee, Domain Id:1 | 2 | 1 | 1 |
2013-03-21 05:24:45 | INFO | 0 | NULL | 0 |
-Thanks
Sangeetha
-----Original Message-----
From: Murali Reddy [mailto:murali.re...@citrix.com]
Sent: Wednesday, March 20, 2013 7:18 AM
To: Kelven Yang; cloudstack-...@incubator.apache.org
Subject: CLOUDSTACK-1568, CLOUDSTACK-1664: Fix ActionEvent interception
and optimize @DB lookup with caching
Kelven, I see that you fixed action event issue in below commit. But I am
still running into some issues. While working on CLOUDSTACK-1673 I
noticed that in case of AccountManagerImpl, there are multiple methods
with same name. So in that case getAnnotation on the method is returning
null even though there is ActionEvent annotation. If I rename method then
action event annotation works fine. You can repro it by creating user
(there are two createUser methods in AccountManagerImpl). I looked at
ComponentMethodProxyCache to see if I can figure the problem but with no
luck. If you get a chance please try once.
> Action Events are not logged due to spring changes
> --------------------------------------------------
>
> Key: CLOUDSTACK-1664
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1664
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.1.0
> Environment: Build from 4.1
> Reporter: Sangeetha Hariharan
> Assignee: Kelven Yang
> Priority: Critical
> Fix For: 4.1.0
>
>
> ActionEvent annotations are in manager Impl. Spring proxies the interface and
> not the implementing class. Since there are not annotations at the interface
> level, needToIntercept method in ActionEventInterceptor always returns false.
> TransactionContextBuilder intercepts by getting the implementing class and
> going through all the methods in it to match the method name. Going through
> all the methods every time may not be efficient. There could be multiple
> methods with same name, so matching by method name could be error prone
> aswell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
