[
https://issues.apache.org/jira/browse/CLOUDSTACK-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616094#comment-13616094
]
Rohit Yadav commented on CLOUDSTACK-1818:
-----------------------------------------
In 4.1, DatabaseCreator is only used by developers to deploy database, users
will still use cloud-setup-databases so why does it even matter to have
upgrading logic in server. Or make DababaseCreator ready to invoke
DatabaseUpgradeChecker?
Secondly, this code is not on master branch so we will needs to apply on
masters. Thirdly, DatabaseCreator does not need spring stuff, why do we need
server/resources/com/cloud/upgrade/databaseCreatorContext.xml?
On masters to make cloudstack-setup-databases use DatabaseCreator we need to
get all classpaths to cloud-server artifact and path to setup/db/db while it is
being packaged. If someone from packaging can take a look on how it is done as
per new packaging for other scripts or share the same, we will use
cloudstack-setup-databases just as a wrapper which does some processing and
executes DatabaseCreator.
Lastly, what's the point of a code freeze and ml discussion if we decided not
to touch it for 4.1 and we keep pushing commits around it?
> DatabaseCreator is not invoking UpgradeChecker to run upgrade logic written
> in Java, which is required for a success upgrade process
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-1818
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1818
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.1.0, 4.2.0
> Reporter: Kelven Yang
> Assignee: Kelven Yang
> Priority: Blocker
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
