[
https://issues.apache.org/jira/browse/CLOUDSTACK-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619327#comment-13619327
]
ASF subversion and git services commented on CLOUDSTACK-1158:
-------------------------------------------------------------
Commit ea0daeaee3f0c2d29821674a836e655fa844fb07 in branch refs/heads/master
from [~widodh]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ea0daea ]
CLOUDSTACK-1158: Wrap qemu-img into it's own util
Signed-off-by: Edison Su <[email protected]>
> Wrap qemu-img instead of using simpleBashScript
> -----------------------------------------------
>
> Key: CLOUDSTACK-1158
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1158
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM
> Affects Versions: 4.0.0
> Reporter: Wido den Hollander
> Assignee: Wido den Hollander
> Fix For: 4.2.0
>
>
> Currently when we are doing something with qemu-img in the KVM Agent we do
> things like this:
> ..
> String result = executeBashScript("qemu-img --help|grep convert");
> ..
> Script.runSimpleBashScript("qemu-img convert"
> ..
> This is not reliable and could be fixed by wrapping qemu-img like this:
> QemuImg.convert(String sourceFormat, String source, String destFormat, string
> dest);
> This could then handle all the stuff like checking the output and more
> importantly also checking the exit status of Qemu to see if everything works.
> It could throw exceptions where needed so it makes life easier when doing
> such operations in the KVM Agent.
> Hopefully we can then also get rid of all kinds of bash scripts being called
> by the KVM Agent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
