[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708281#comment-13708281
 ] 

ASF subversion and git services commented on CLOUDSTACK-3431:
-------------------------------------------------------------

Commit b13485493733585cce3044d209063bf37a774ece in branch refs/heads/master 
from [~toshiaki.hatano]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b134854 ]

CLOUDSTACK-3431: KVM: cloudstack-plugin-hypervisor-kvm with BridgeVifDriver 
doesn't cleanup vNet due to multiple reasons

- Move vnetBridge clean up function from LibvirtComputingResource to 
BridgeVifDriver
-- since only BridgeVifDriver have to handle this event
- LibvirtComputingResource now properly call VifDriver.unplug() when it 
receives UnPlugCommand

- Remove not working and no longer used method getVnet(String) from 
VirtualMachineName
- Remove not working and no longer used method getVnet() from StopCommand
- Remove unused constructer StopCommand(VirtualMachine, String, boolean) from 
StopCommand
- Remove unused member vnet from StopCommand
- Remove unused member _modifyVlanPath from OvsVifDriver

Tested with 2 KVM hosts and confirmed it correctly manipulate vnetBridge with 
start, stop, migrate, plug, and unplug event

Signed-off-by: Hugo Trippaers <[email protected]>

                
> KVM: cloudstack-plugin-hypervisor-kvm with BridgeVifDriver doesn't cleanup 
> vNet due to multiple reasons
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-3431
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3431
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Hypervisor Controller, KVM
>    Affects Versions: 4.1.0, 4.1.1, 4.2.0
>         Environment: KVM hyper visor with BridgeVifDriver
>            Reporter: Toshiaki Hatano
>            Assignee: Toshiaki Hatano
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> When last VM which uses the guest network disappeared on the host, 
> KVM agent should clean up it's guest network bridge and vlanIf but it doesn't.
> Biggest cause is missing parameter on calling modifyvlan.sh.
> But I found there're more errors related to this issue.
> I found at least 3.
> 1) missing parameter on calling modifyvlan.sh in 
> com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.cleanupVnet(Connect,
>  String)
> 2) VirtualMachineName.getVnet(String) will never return vnet
> 3) com.cloud.agent.api.StopCommand.getVnet(String) will never return vnet

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to