[
https://issues.apache.org/jira/browse/CLOUDSTACK-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723738#comment-13723738
]
ASF subversion and git services commented on CLOUDSTACK-3937:
-------------------------------------------------------------
Commit 62a71e055bbd69a195258f6fc871378070efdcc2 in branch refs/heads/master
from [~koushikd]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=62a71e0 ]
CLOUDSTACK-3937: Attaching uploaded volume is failing
The method getCommandHostDelegation(long hostId, Command cmid) got overidden in
VmwareGuru.java as part of
commit bfe30cd2e31906365a306d87fe331ccdcec5c33c. Earlier there was no HV
specific implementation and copy
volume from secondary to primary worked fine. With the Vmware specific change
the code was getting hit even
in case of XS and other hypervisors and failed with NPE.
Now there is a check in the Vmware implementation to check if the HV is of type
Vmware.
> Attaching uploaded volume is failing
> ------------------------------------
>
> Key: CLOUDSTACK-3937
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-3937
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Storage Controller
> Affects Versions: 4.2.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Priority: Blocker
> Fix For: 4.2.0
>
>
> This got introduced as part of bfe30cd2e31906365a306d87fe331ccdcec5c33c.
> The uploaded volume is first copied from secondary to primary and then
> attached to a VM. Due to the above commit the copy logic is broken in all HVs
> except Vmware.
> There is a method
> public Pair<Boolean, Long> getCommandHostDelegation(long hostId, Command
> cmd)
> that is overidden in VmwareGuru.java and not in any other specific HV guru.
> Earlier this method was not overridden in any HV guru and so the below method
> used to fall back on the default behavior and used to return the passed
> hostId but now with the Vmware guru implementation request for any HV gets
> processed by Vmware guru and results in NPE.
> public long getGuruProcessedCommandTargetHost(long hostId, Command cmd) {
> for(HypervisorGuru guru : _hvGuruList) {
> Pair<Boolean, Long> result =
> guru.getCommandHostDelegation(hostId, cmd);
> if (result.first()) {
> return result.second();
> }
> }
> return hostId;
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
