Marcus Sorensen created CLOUDSTACK-4887:
-------------------------------------------
Summary: CLVM broken
Key: CLOUDSTACK-4887
URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4887
Project: CloudStack
Issue Type: Bug
Security Level: Public (Anyone can view this level - this is the default.)
Components: KVM
Affects Versions: Future
Reporter: Marcus Sorensen
Assignee: Chris Suich
Priority: Blocker
Fix For: Future
Chris,
I think commit 180cfa19 broke CLVM primary storage for KVM. I'm failing VM
deploy from template. I've been building a 'sanity check' test that focuses on
the KVM specific suff (tests storage types and supported host OS for now), and
this bubbled up.
I reverted this one part in my local code and am testing (seems to fix it), but
since I'm not clear on the refactor efforts I'm not sure what it should really
be changed to in order to meet your requirements and keep CLVM working.
@@ -65,7 +68,7 @@ public class StorageSubsystemCommandHandlerBase implements
StorageSubsystemComma
DataStoreTO srcDataStore = srcData.getDataStore();
DataStoreTO destDataStore = destData.getDataStore();
- if ((srcData.getObjectType() == DataObjectType.TEMPLATE) &&
(srcDataStore instanceof NfsTO) && (destData.getDataStore().getRole() ==
DataStoreRole.Primary)) {
+ if ((srcData.getObjectType() == DataObjectType.TEMPLATE) &&
(destData.getObjectType() == DataObjectType.TEMPLATE &&
destData.getDataStore().getRole() == DataStoreRole.Primary)) {
//copy template to primary storage
return processor.copyTemplateToPrimaryStorage(cmd);
} else if (srcData.getObjectType() == DataObjectType.TEMPLATE &&
srcDataStore.getRole() == DataStoreRole.Primary && destDataStore.getRole() ==
DataStoreRole.Primary) {
4.2 command:
{ Cmd , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 100111,
[{"org.apache.cloudstack.storage.command.CopyCommand":{"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/201/fe75caa3-78fd-38ba-b34c-101d0502df2e.qcow2","origUrl":"http://marcus.mlsorensen.com/cloudstack-extras/tiny-centos-63.qcow2","uuid":"4795671b-dd72-4e62-9aac-c0e1d6732003","id":201,"format":"QCOW2","accountId":1,"checksum":"44cd0e6330a59f031460bc18a40c95a2","hvm":true,"displayText":"tiny","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"nfs://172.17.10.10:/nfs/secondary","_role":"Image"}},"name":"201-1-2b35186d-79a6-33dc-8b33-83eb650e5e1d","hypervisorType":"KVM"}},"destTO":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"73f86d88-ccff-4dfb-ac86-2d76b7891117","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"08e8d399-b238-48f9-a497-1f7f5285d655","id":2,"poolType":"CLVM","host":"localhost","path":"vg0","port":0}},"name":"ROOT-6","size":1073741824,"volumeId":6,"vmName":"i-1-6-VM","accountId":1,"format":"QCOW2","id":6,"hypervisorType":"KVM"}},"executeInSequence":true,"wait":10800}}]
}
4.2 response:
{ Ans: , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 110,
[{"org.apache.cloudstack.storage.command.CopyCmdAnswer":{"newData":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"path":"f69879c0-ae3b-433a-841f-f1f5afc04fc7","accountId":0,"format":"RAW","id":0}},"result":true,"wait":0}}]
}
master command:
{ Cmd , MgmtId: 52241639751, via: 1(devcloud-kvm-u), Ver: v1, Flags: 100111,
[{"org.apache.cloudstack.storage.command.CopyCommand":{"srcTO":{"org.apache.cloudstack.storage.to.TemplateObjectTO":{"path":"template/tmpl/1/4/02170718-210a-3d8c-91a2-2793ed52f1d8.qcow2","origUrl":"http://download.cloud.com/releases/2.2.0/eec2209b-9875-3c8d-92be-c001bd8a0faf.qcow2.bz2","uuid":"07088e98-1fda-11e3-a1ff-000c29d82947","id":4,"format":"QCOW2","accountId":1,"checksum":"ed0e788280ff2912ea40f7f91ca7a249","hvm":false,"displayText":"CentOS
5.5(64-bit) no GUI
(KVM)","imageDataStore":{"com.cloud.agent.api.to.NfsTO":{"_url":"nfs://172.17.10.10:/nfs/secondary","_role":"Image"}},"name":"centos55-x86_64","hypervisorType":"KVM"}},"destTO":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"e08f2a84-0d8b-4c6e-9593-a7554fd57b78","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"0f77072d-c76f-449c-bc6d-e2504644c0ca","id":2,"poolType":"CLVM","host":"localhost","path":"vg0","port":0}},"name":"ROOT-7","size":8589934592,"volumeId":7,"vmName":"i-1-7-VM","accountId":1,"format":"QCOW2","id":7,"hypervisorType":"KVM"}},"executeInSequence":true,"wait":10800}}]
}
master response:
{ Ans: , MgmtId: 52241639751, via: 1, Ver: v1, Flags: 110,
[{"com.cloud.agent.api.Answer":{"result":false,"details":"not implemented
yet","wait":0}}] }
--
This message was sent by Atlassian JIRA
(v6.1#6144)
