[
https://issues.apache.org/jira/browse/CLOUDSTACK-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841957#comment-13841957
]
ASF subversion and git services commented on CLOUDSTACK-5390:
-------------------------------------------------------------
Commit c305e4ec5a0cf3e0403b96b1613316ac19155255 in branch refs/heads/4.3 from
[~alena1108]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c305e4e ]
CLOUDSTACK-5390: obey page/pageSize parameters in listNetworks call
Conflicts:
server/src/com/cloud/network/NetworkServiceImpl.java
> listNetworks: pageSize and page parameters are not applied properly
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-5390
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5390
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.3.0
> Reporter: Alena Prokharchyk
> Assignee: Alena Prokharchyk
> Fix For: 4.3.0
>
>
> ListNetworks call does numerous calls to the DB to get diff kinds of networks
> based on search criteria (Isolated and Shared). The result sets are combined
> and returned to the API. As page/pageSize parameters are passed only to the
> DB call, they are not respected while generating the final set.
> There can be 2 ways to fix the problem:
> 1) generate only one call to the DB
> or
> 2) After the result set is finalized, apply the pagination to it.
> I would go with #2 as changing the db call can introduce regressions plus its
> very hard to achieve given the number of joins happening based on the search
> criteria.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
