[
https://issues.apache.org/jira/browse/CLOUDSTACK-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843238#comment-13843238
]
ASF subversion and git services commented on CLOUDSTACK-5145:
-------------------------------------------------------------
Commit c2d5ed2ec91e4116b5daaf718f93102e2ed5a309 in branch refs/heads/4.2 from
[~kishan]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c2d5ed2 ]
CLOUDSTACK-5145 : Added permission checks while listing network ACLs and acl
Items. Users will be able to list items that they have access to.
Conflicts:
server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java
server/test/com/cloud/vpc/NetworkACLServiceTest.java
> ListNetworkACL API should list ACLs owned by the user only
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-5145
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5145
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Kishan Kavala
> Assignee: Kishan Kavala
> Priority: Blocker
> Fix For: 4.2.1, 4.3.0
>
>
> ListNetworkACL API should filter ACLs by caller and list ACLs which can be
> accessed by the user only.
> If API call is not called with a networkid or other filter, every ACL in the
> system is dumped, which is both a performance issue and a security issue. If
> a networkid is provided, but the network doesn't have an ACL list or any ACL
> items attached, the same issue occurs.
> Likewise, listNetworkACLLists gives access to see non-owned lists, which in
> turn gives vpc ids for non-owned resources.
> Example:
> 1. Set up a zone
> 2. Create a VPC or network as admin
> 3. Create an ACL list for the network
> 4. Create a new domain and unprivileged user
> 5. Generate API keys for user
> 6. Issue a 'listNetworkACLs' API call. You should see the ACL list items from
> the admin-owned list
> 7. Issue a 'listNetworkACLLists' API call referencing aclid from non-owned
> acl item. You should see the acl list info and which vpc it belongs to.
> 8. Listing the vpc attached to the acl list properly stops with an
> 'unauthorized' response as step 7 above should.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
