[jira] [Created] (CLOUDSTACK-5453) Site-to-site VPN connection status monitoring is broken in KVM

[Sheng Yang (JIRA)]

Sheng Yang created CLOUDSTACK-5453:
--------------------------------------

             Summary: Site-to-site VPN connection status monitoring is broken 
in KVM
                 Key: CLOUDSTACK-5453
                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5453
             Project: CloudStack
          Issue Type: Bug
      Security Level: Public (Anyone can view this level - this is the default.)
    Affects Versions: 4.2.0, 4.1.0, 4.3.0
            Reporter: Sheng Yang
            Assignee: Sheng Yang
            Priority: Critical
             Fix For: 4.2.1, 4.1.2, 4.3.0


It's broken by Edison's commit:

commit 7f104b1feb489ae09b1a2060262a122deda44a8e
Author: Edison Su <sudi...@gmail.com>
Date:   Fri Oct 12 18:24:50 2012 -0700

    [PATCH] CLOUDSTACK-335: fix lb for vpc on kvm

diff --git 
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
index 2bb1145..7e53f03 100755
--- 
a/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
+++ 
b/core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java

@@ -520,7 +590,7 @@ public class VirtualRoutingResource implements Manager {
         }
         
         final String result = routerProxy("checkbatchs2svpn.sh", routerIP, 
args);
-        if (result == null || result.isEmpty()) {
+        if (result != null) {
             return new CheckS2SVpnConnectionsAnswer(cmd, false, 
"CheckS2SVpnConneciontsCommand failed");
         }
         return new CheckS2SVpnConnectionsAnswer(cmd, true, result);




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)