[
https://issues.apache.org/jira/browse/CLOUDSTACK-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kishan Kavala resolved CLOUDSTACK-5317.
---------------------------------------
Resolution: Not A Problem
Cloudstack takes a lazy approach for public IP acquire or release. IP is marked
as allocated in Db, but the commands are not sent to VR until a service uses
this IP.
More info from code:
"CloudStack will take a lazy approach to associate an acquired public IP to a
network service provider as it will not know what service an acquired IP will
be used for. An IP is actually associated with a provider when first rule is
applied. Similarly when last rule on the acquired IP is revoked, IP is not
associated with any provider but still be associated with the account. At this
point just mark IP as allocated or released."
> associateIpAddress command doesnt fails on non upgraded router
> --------------------------------------------------------------
>
> Key: CLOUDSTACK-5317
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5317
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Upgrade, Virtual Router
> Affects Versions: 4.3.0
> Environment: upgrade from 3.0.7 to 4.3.0
> Reporter: shweta agarwal
> Assignee: Kishan Kavala
> Priority: Critical
> Fix For: 4.3.0
>
>
> Repro steps:
> 1. On 3.0.7 setup create a network
> 2. upgrade to 4.3
> 3.Aquire Ip on network when router is not upgraded
> Bug:
> IP Associate command will succeed
> Exception :
> IP Associate command should fail sating router needs upgrade:
> MS log shows :
> 2013-11-29 16:33:56,045 DEBUG [c.c.a.ApiServlet]
> (catalina-exec-8:ctx-619dddf1) ===START=== 10.146.0.132 -- GET
> command=associateIpAddress&response=json&sessionkey=CNU%2FUxmL5sTxIFWo8PSATnLucYk%3D&networkid=597e7f42-8f78-4c51-954b-c75867d2a17d&_=1385723056001
> 2013-11-29 16:33:56,061 DEBUG [c.c.n.IpAddressManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) Associate IP address called by
> the user 2 account 2
> 2013-11-29 16:33:56,062 DEBUG [c.c.n.IpAddressManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) Associate IP address lock acquired
> 2013-11-29 16:33:56,067 DEBUG [c.c.n.IpAddressManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) Got 10.147.51.31 to assign for
> account 2 in zone 1
> 2013-11-29 16:33:56,113 DEBUG [c.c.n.IpAddressManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) Releasing lock account
> Acct[2-admin]
> 2013-11-29 16:33:56,114 DEBUG [c.c.n.IpAddressManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) Associate IP address lock released
> 2013-11-29 16:33:56,324 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) submit async job-131, details:
> AsyncJobVO {id:131, userId: 2, accountId: 2, instanceType: IpAddress,
> instanceId: 22, cmd:
> org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd, cmdInfo:
> {"id":"22","response":"json","sessionkey":"CNU/UxmL5sTxIFWo8PSATnLucYk\u003d","cmdEventType":"NET.IPASSIGN","ctxUserId":"2","httpmethod":"GET","_":"1385723056001","ctxAccountId":"2","networkid":"597e7f42-8f78-4c51-954b-c75867d2a17d","ctxStartEventId":"457"},
> cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
> null, initMsid: 233845177509765, completeMsid: null, lastUpdated: null,
> lastPolled: null, created: null}
> 2013-11-29 16:33:56,324 INFO [o.a.c.f.j.i.AsyncJobMonitor]
> (Job-Executor-29:ctx-9f8c8b7f) Add job-131 into job monitoring
> 2013-11-29 16:33:56,324 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
> (Job-Executor-29:ctx-9f8c8b7f) Executing AsyncJobVO {id:131, userId: 2,
> accountId: 2, instanceType: IpAddress, instanceId: 22, cmd:
> org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd, cmdInfo:
> {"id":"22","response":"json","sessionkey":"CNU/UxmL5sTxIFWo8PSATnLucYk\u003d","cmdEventType":"NET.IPASSIGN","ctxUserId":"2","httpmethod":"GET","_":"1385723056001","ctxAccountId":"2","networkid":"597e7f42-8f78-4c51-954b-c75867d2a17d","ctxStartEventId":"457"},
> cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
> null, initMsid: 233845177509765, completeMsid: null, lastUpdated: null,
> lastPolled: null, created: null}
> 2013-11-29 16:33:56,325 DEBUG [c.c.a.ApiServlet]
> (catalina-exec-8:ctx-619dddf1 ctx-173f6e25) ===END=== 10.146.0.132 -- GET
> command=associateIpAddress&response=json&sessionkey=CNU%2FUxmL5sTxIFWo8PSATnLucYk%3D&networkid=597e7f42-8f78-4c51-954b-c75867d2a17d&_=1385723056001
> 2013-11-29 16:33:56,400 DEBUG [c.c.n.IpAddressManagerImpl]
> (Job-Executor-29:ctx-9f8c8b7f ctx-173f6e25) Associating ip Ip[10.147.51.31-1]
> to network Ntwk[204|Guest|8]
> 2013-11-29 16:33:56,506 DEBUG [c.c.n.IpAddressManagerImpl]
> (Job-Executor-29:ctx-9f8c8b7f ctx-173f6e25) Successfully associated ip
> address 10.147.51.31 to network Ntwk[204|Guest|8]
> 2013-11-29 16:33:56,564 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
> (Job-Executor-29:ctx-9f8c8b7f ctx-173f6e25) Complete async job-131,
> jobStatus: SUCCEEDED, resultCode: 0, result:
> org.apache.cloudstack.api.response.IPAddressResponse/ipaddress/{"id":"6b59e05e-243a-4f56-a563-b19d562257ab","ipaddress":"10.147.51.31","allocated":"2013-11-29T16:33:56+0530","zoneid":"71c3d210-e0f7-4ea0-80b3-1a3769cdaeb2","zonename":"xen","issourcenat":false,"account":"admin","domainid":"1","domain":"ROOT","forvirtualnetwork":true,"vlanid":"92e13e64-3f00-4edd-9f35-a203721aee4b","vlanname":"51","isstaticnat":false,"issystem":false,"associatednetworkid":"597e7f42-8f78-4c51-954b-c75867d2a17d","associatednetworkname":"vr1","networkid":"c1e501e4-41a3-47a0-8cf3-472895bc68ae","state":"Allocating","physicalnetworkid":"8b22e636-7774-44cb-b670-63f75c2fd157","tags":[],"isportable":false}
> 2013-11-29 16:33:56,615 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl]
> (Job-Executor-29:ctx-9f8c8b7f) Done executing
> org.apache.cloudstack.api.command.user.address.AssociateIPAddrCmd for job-131
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
