[
https://issues.apache.org/jira/browse/CLOUDSTACK-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867135#comment-13867135
]
Alena Prokharchyk commented on CLOUDSTACK-5502:
-----------------------------------------------
I agree that its ambiguous that we treat NULL and untagged the same way. Its
NULL in the network, and "untagged" in corresponding vlans:
mysql> select broadcast_uri from networks where traffic_type='guest' and
removed is null;
+---------------+
| broadcast_uri |
+---------------+
| NULL |
| NULL |
| NULL |
+---------------+
mysql> select vlan_id from vlan;
+----------+
| vlan_id |
+----------+
| untagged |
| untagged |
| untagged |
+----------+
Daan, I think your fix should be changed (revert the old code, and commit a new
fix). Instead of changing ConfigurationManager, you need to fix addVlanRange
API class. Basically when "untagged" is passed in, convert it to NULL there as
if nothing has been passed in. Then let the networking code translate it to
whatever it understands and perform the validation. In this case you will
preserve the old behavior.
Marcus, please let me/Daan know if the possible fix I've suggested, breaks
anything on your side. By reviewing the code, I don't see that anything will be
wrong after applying the fix I've suggested.
> [Automation] createVlanIpRange API failing, if you pass VLAN
> -------------------------------------------------------------
>
> Key: CLOUDSTACK-5502
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5502
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.3.0
> Environment: KVM Basic Zone with SG
> Reporter: Rayees Namathponnan
> Assignee: Daan Hoogland
> Priority: Blocker
> Fix For: 4.3.0
>
>
> This issue found in KVM basic zone with SG automation run; test cases from
> below suite filed
> integration.component.test_multiple_ip_ranges.
> Steps to reproduce
> Step 1 : Create basic zone with SG
> Step 2 : Crete IP VLAN Range with below command (pass vlan=untagged)
> http://xxx.xxxx.xxx.xxx:8096/?command=createVlanIpRange&gateway=10.223.251.1&forvirtualnetwork=false&startip=10.223.251.3&podid=0253bcbf-e636-4776-9e8c-216b70d195a2&zoneid=a9912aa8-a231-44d9-a70b-9d53e6db2d27&netmask=255.255.255.192&vlan=untagged
> Result;
> API command failed with error
> { "createvlaniprangeresponse" :
> {"uuidList":[],"errorcode":431,"cserrorcode":4350,"errortext":"Vlan doesn't
> match vlan of the network"} }
> this API command works only, if you are not passing any VLAN
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
