[
https://issues.apache.org/jira/browse/CLOUDSTACK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932035#comment-13932035
]
Alena Prokharchyk commented on CLOUDSTACK-6232:
-----------------------------------------------
Daan, looks like we also has to change createVlanIpRange call in addition to
createNetwork, otherwise the fix would be partial. This call is executed when
the network is already created, and you want to extend its range.
Configuration ManagerImpl, public Vlan
createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd)
// If networkId is not specified, and vlan is Virtual or Direct
// Untagged, try to locate default networks
if (forVirtualNetwork) {
if (network == null) {
// find default public network in the zone
networkId =
_networkModel.getSystemNetworkByZoneAndTrafficType(zoneId,
TrafficType.Public).getId();
network = _networkModel.getNetwork(networkId);
} else if (network.getGuestType() != null ||
network.getTrafficType() != TrafficType.Public) {
throw new InvalidParameterValueException("Can't find Public
network by id=" + networkId);
}
} else {
if (network == null) {
if (zone.getNetworkType() == DataCenter.NetworkType.Basic) {
networkId =
_networkModel.getExclusiveGuestNetwork(zoneId).getId();
network = _networkModel.getNetwork(networkId);
} else {
network =
_networkModel.getNetworkWithSecurityGroupEnabled(zoneId);
if (network == null) {
throw new InvalidParameterValueException("Nework id is
required for Direct vlan creation ");
}
networkId = network.getId();
zoneId = network.getDataCenterId();
}
CHANGE THIS LINE BY ADDING : } else if (network.getGuestType() ==
null || network.getGuestType() == Network.GuestType.Isolated) { WITH
} else if (network.getGuestType() == null || (network.getGuestType() ==
Network.GuestType.Isolated &&
areServicesSupportedByNetworkOffering(ntwkOff.getId(), Service.SourceNat)))
throw new InvalidParameterValueException("Can't create direct
vlan for network id=" + networkId + " with type: " + network.getGuestType());
}
}
> isolated network can no longer reserve ip range
> -----------------------------------------------
>
> Key: CLOUDSTACK-6232
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6232
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller
> Affects Versions: 4.2.0, 4.3.0, 4.4.0
> Reporter: Daan Hoogland
> Assignee: Daan Hoogland
> Priority: Blocker
> Fix For: 4.4.0
>
>
> We found a functionality that we use once in a while no longer is permitted
> in 4.2.1. It seems in line with the philosophy of cloudstack but is hurting
> our operation. In 4.1.1 we could add a bridged network with the following
> network offering:
> cno.traffictype = "GUEST"
> cno.guestiptype = "Isolated"
> cno.specifyipranges = True
> cno.specifyvlan = False
> cno.serviceproviderlist = [ { "service": "Connectivity", "provider":
> "NiciraNvp"},
> { "service": "UserData", "provider":
> "VirtualRouter"},
> { "service": "Dhcp", "provider": "VirtualRouter"}
> ]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
