[
https://issues.apache.org/jira/browse/CLOUDSTACK-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011658#comment-14011658
]
Marcus Sorensen commented on CLOUDSTACK-6088:
---------------------------------------------
I've rebased this and committed it to master. It would still be nice to do the
isCorrectExtension improvement.
> template validation patch (4.2) needs to be rebased for master
> --------------------------------------------------------------
>
> Key: CLOUDSTACK-6088
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6088
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: Future
> Reporter: Marcus Sorensen
> Assignee: Laszlo Hornyak
> Fix For: Future
>
> Attachments: template-content-validation-v2.patch
>
>
> Submitting this 4.2 patch that validates template contents upon initial
> download, such that a qcow2 can't be named '.img', or a .vmdk descriptor file
> (which is text) can't be successfully uploaded as a template.
> It needs to be rebased/integrated into master, and perhaps some more testing
> to verify that it correctly catches all template types.
> For bonus points, we can use TemplateUtils.isCorrectExtension to clean up a
> lot of the code that verifies extensions, look for "qcow2.gz" in
> HypervisorTemplateAdaptor and VolumeManagerImpl (or their master equivalents)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
