[
https://issues.apache.org/jira/browse/CLOUDSTACK-5583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053670#comment-14053670
]
Mandar Barve commented on CLOUDSTACK-5583:
------------------------------------------
I followed the steps you mentioned using a software iSCSI target on a VM and
could reproduce the problem. I do see INSUFFICIENT_SPACE exception being thrown
when "xe snapshot-revert" is called by the vmopsSnapshot plug in.
The problem looks like this xe command is called via os.system module by the
python plugin. xe is a different program and any error/exception thrown by this
won't get propagated to the caller. To fix this os.system can be replaced by
subprocess.call with a check for the return code. I tried this and this will
return a non zero error code to the management server. It may still not return
the child process's exception code.
> vmopsSnapshot plug-in (XenServer) does not return an error when it should
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-5583
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5583
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Xen
> Affects Versions: 4.3.0
> Environment: XenServer 6.1
> Reporter: Mike Tutkowski
> Fix For: 4.4.0
>
>
> I tried to revert a VM snapshot and one of my storage repositories had an
> insufficient amount of space. The plug-in did not return an error message (it
> returned "0").
> From the XenServer vmopsSnapshot plug-in's revert_memory_snapshot method:
> [root@XenServer-6 ~]# xe snapshot-revert
> snapshot-uuid=82e33f6d-59f3-a26d-4171-d51cd58716d8
> Error code: SR_BACKEND_FAILURE_44
> Error parameters: , There is insufficient space,
> An error should be returned from the plug-in instead of "0".
--
This message was sent by Atlassian JIRA
(v6.2#6252)
