[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071334#comment-14071334
 ] 

ASF subversion and git services commented on CLOUDSTACK-7153:
-------------------------------------------------------------

Commit c43b56998a7e04c3a0a0f034666aec76c585c48e in cloudstack's branch 
refs/heads/master from [~damoder.reddy]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c43b569 ]

CLOUDSTACK-7153: addNicToVirtualMachine not BaseAsyncCreate but creates an 
entity


> addNicToVirtualMachine not BaseAsyncCreate but creates an entity
> ----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7153
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7153
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.4.0
>            Reporter: Damodar Reddy T
>            Assignee: Damodar Reddy T
>             Fix For: 4.5.0
>
>
> addNicToVirtualMachine not BaseAsyncCreate but creates an entity.
> We need them to be BaseAsyncCreate so that Eventbus while publishing the 
> completed events can put in the entity id. Right now there is a generic logic 
> where after create function when the id is created its pushed into the 
> context so that Eventbus can use it to publish the created UUID. If its not 
> baseAsyncCreate you will have to go into each api and put the id in the 
> context.
> Currently following is the generic code had put in ApiServer.java. We will 
> have to do specifically into your api. Do this only if there is a hard reason 
> not to make it baseasyncCreate
> Class entityClass = 
> EventTypes.getEntityClassForEvent(createCmd.getEventType());
> if (entityClass != null)
> ctx.putContextParameter(entityClass.getName(), objectId);



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to