[
https://issues.apache.org/jira/browse/CLOUDSTACK-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090969#comment-14090969
]
Rohit Yadav commented on CLOUDSTACK-5512:
-----------------------------------------
I guess we should remove it, because one could simply mock say a vhd by
renaming a text file this will still work. In this case we should remove the
check totally and dumb down by assuming whatever format the user has chosen
when registering. I'll start a discussion thread on ML, just in case anyone has
reasons to object to this.
> template format name checking is crude and doesn't work with advanced URLs
> --------------------------------------------------------------------------
>
> Key: CLOUDSTACK-5512
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-5512
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.0.0, 4.1.0, 4.2.0
> Reporter: Marcus Sorensen
> Fix For: 4.4.0
>
>
> Template name checking currently just looks at the very end of the url
> string. e.g.:
> private void checkFormat(String format, String url) {
> if((!url.toLowerCase().endsWith("vhd"))
> This breaks functionality such as registering a template via an S3 pre-signed
> URL, or anything where the file extension is not the last part of the URL. We
> should at least attempt to parse the URL for filename vs parameters.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
