[
https://issues.apache.org/jira/browse/CLOUDSTACK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189776#comment-14189776
]
ASF GitHub Bot commented on CLOUDSTACK-7541:
--------------------------------------------
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/28
CLOUDSTACK-7541: Added restriction to not allow custom disk offering with
disksize
Added restriction to not allow custom disk offering with disksize
UI doesn't allow but with API we were able to create custom disk offering
with disk size
which was causing this issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-7541
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit faf037f42a662660838f6ff129b11b8e52421a7e
Author: Anshul Gangwar <[email protected]>
Date: 2014-10-22T04:29:42Z
CLOUDSTACK-7541: Added restriction to not allow custom disk offering with
disksize
UI doesn't allow but with API we were able to create custom disk offering
with disk size
which was causing this issue
----
> Volume gets created with the size mentioned in the custom disk offering
> ------------------------------------------------------------------------
>
> Key: CLOUDSTACK-7541
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7541
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Volumes
> Affects Versions: 4.5.0
> Environment: latest build from 4.5 with commit
> 932ea253eb8c65821503ab9db301073cdb2a413e
> Reporter: Sanjeev N
> Assignee: Anshul Gangwar
> Priority: Critical
> Fix For: 4.5.0
>
> Attachments: cloud.dmp, management-server.rar
>
>
> Volume gets created with the size mentioned in the custom disk offering
> Steps to reproduce:
> ==============
> 1.Bring up cs with latest build
> 2.Create custom disk offering with disk size say 2
> 3.Create data disk using this offering and provide disk size as 1 while
> creating data disk
> Expected Result:
> ==============
> Since the disk offering is of type custom , volume should be created with
> size given during volume creation instead of taking it from the disk offering.
> If the disk offering is custom then the volume creation must ignore the size
> given in the offering and should create volume with size provide while
> creating volume.
> Actual Result:
> ===========
> Disk got created with size mentioned in disk offering rather than the size
> given during volume creation time.
> Observations:
> ===========
> http://10.147.38.153:8096/client/api?command=createDiskOffering&isMirrored=false&name=custom&displaytext=custom&storageType=shared&cacheMode=none&provisioningType=thin&customized=true&disksize=2
> { "creatediskofferingresponse" : { "diskoffering" :
> {"id":"2ddb8b79-9592-4b8c-8bd9-3d32c582873b","name":"custom","displaytext":"custom","disksize":2,"created":"2014-09-12T23:33:24+0530","iscustomized":true,"storagetype":"shared","provisioningtype":"thin","displayoffering":true}
> } }
> http://10.147.38.153:8080/client/api?command=createVolume&response=json&sessionkey=USf4e%2BpnzNiyWyq1PCeDFswjB%2BU%3D&name=custom&zoneId=2c67c83e-b8c3-42d0-a37b-b37287ac84dd&diskOfferingId=2ddb8b79-9592-4b8c-8bd9-3d32c582873b&size=1&_=1410525928417
> { "queryasyncjobresultresponse" :
> {"accountid":"638d4e82-341f-11e4-a4c9-06097e000023","userid":"638d5ddc-341f-11e4-a4c9-06097e000023","cmd":"org.apache.cloudstack.api.command.admin.volume.CreateVolumeCmdByAdmin","jobstatus":1,"jobprocstatus":0,"jobresultcode":0,"jobresulttype":"object","jobresult":{"volume":{"id":"42f24df4-b4ae-4b4c-80ce-ea1b5daf12bd","name":"custom","zoneid":"2c67c83e-b8c3-42d0-a37b-b37287ac84dd","zonename":"zone1","type":"DATADISK","provisioningtype":"thin","size":2147483648,"created":"2014-09-12T23:34:32+0530","state":"Allocated","account":"admin","domainid":"2caca782-341f-11e4-a4c9-06097e000023","domain":"ROOT","storagetype":"shared","hypervisor":"None","diskofferingid":"2ddb8b79-9592-4b8c-8bd9-3d32c582873b","diskofferingname":"custom","diskofferingdisplaytext":"custom","destroyed":false,"isextractable":true,"tags":[],"displayvolume":true,"quiescevm":false,"jobid":"edf1a066-63b0-400b-bf15-4f77bf659206","jobstatus":0}},"jobinstancetype":"Volume","jobinstanceid":"42f24df4-b4ae-4b4c-80ce-ea1b5daf12bd","created":"2014-09-12T23:34:32+0530","jobid":"edf1a066-63b0-400b-bf15-4f77bf659206"}
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
