[
https://issues.apache.org/jira/browse/CLOUDSTACK-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196036#comment-14196036
]
ASF subversion and git services commented on CLOUDSTACK-7421:
-------------------------------------------------------------
Commit 0327c2b13e9712a63d865ff755a9fec421eb0af5 in cloudstack's branch
refs/heads/master from [~koushikd]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0327c2b ]
CLOUDSTACK-7421
Unnecessary exception in MS logs while removing default NIC from VM. Following
changes are made:
1. Changed the exception from CloudRuntimeException to
InvalidParameterValueExecption.
2. Moved out validation logic to UserVMManagerImpl from
VirtualMachineManagerImpl.
3. Handling InvalidParameterValueException from async API calls so that they
are not logged as ERROR in MS logs.
> [Automation] Exceptions in orchestrate* methods from
> virtualMachineManagerImpl are shown in log
> -----------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-7421
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7421
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.5.0
> Reporter: Rayees Namathponnan
> Assignee: Koushik Das
> Fix For: 4.5.0
>
>
> Steps to reproduce
> 1 ) Deploy VM
> 2) Add one more nic
> 3) remove default nic the VM
> Result
> Below exception thrown in log, it should be handled with proper messgae
> cloud.vm.VmWorkRemoveNicFromVm for VM 30, job origin: 248
> 2014-08-23 09:50:33,665 ERROR [c.c.v.VmWorkJobDispatcher]
> (Work-Job-Executor-61:ctx-5c747fe0 job-248/job-249) Unable to complete
> AsyncJobVO {id:249, userId: 2, accountId: 2, instanceType: null, instanceId:
> null, cmd: com.cloud.vm.VmWorkRemoveNicFromVm, cmdInfo:
> rO0ABXNyACJjb20uY2xvdWQudm0uVm1Xb3JrUmVtb3ZlTmljRnJvbVZtxM1Xh9nBu10CAAFMAAVuaWNJZHQAEExqYXZhL2xhbmcvTG9uZzt4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1ldAASTGphdmEvbGFuZy9TdHJpbmc7eHAAAAAAAAAAAgAAAAAAAAACAAAAAAAAAB50ABlWaXJ0dWFsTWFjaGluZU1hbmFnZXJJbXBsc3IADmphdmEubGFuZy5Mb25nO4vkkMyPI98CAAFKAAV2YWx1ZXhyABBqYXZhLmxhbmcuTnVtYmVyhqyVHQuU4IsCAAB4cAAAAAAAAABI,
> cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result:
> null, initMsid: 90928106758026, completeMsid: null, lastUpdated: null,
> lastPolled: null, created: Sat Aug 23 09:50:32 PDT 2014}, job origin:248
> com.cloud.utils.exception.CloudRuntimeException: Failed to remove nic from
> VM[User|i-18-30-TestVM] in Ntwk[222|Guest|17], nic is default.
> at
> com.cloud.vm.VirtualMachineManagerImpl.orchestrateRemoveNicFromVm(VirtualMachineManagerImpl.java:2963)
> at
> com.cloud.vm.VirtualMachineManagerImpl.orchestrateRemoveNicFromVm(VirtualMachineManagerImpl.java:4690)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107)
> at
> com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4738)
> at
> com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102)
> at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:503)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
> at
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
> at
> org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
> at
> org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:460)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:744)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
