[
https://issues.apache.org/jira/browse/CLOUDSTACK-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236231#comment-14236231
]
ASF subversion and git services commented on CLOUDSTACK-1052:
-------------------------------------------------------------
Commit 3ea8a1187a825fdbcf7f78198afc00a2f3a8b974 in cloudstack's branch
refs/heads/master from [~vbernat]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3ea8a11 ]
CLOUDSTACK-7195: log wide exceptions in security_group.py
Some try/except in security_group.py catch a lot of exceptions. There
was already one fixed in CLOUDSTACK-1052. Here is another one. We use
logging.exception() to log those exceptions.
Signed-off-by: Vincent Bernat <[email protected]>
Signed-off-by: Pierre-Luc Dion <[email protected]>
> security_group.py broken add_network_rules() exception handling hides all
> errors
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-1052
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1052
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Noa Resare
> Assignee: John Kinsella
> Priority: Minor
>
> Line 695 in version 6f29317 of security_group.py hides all possible errors in
> the add_network_rules() function due to a unfortunate attempt to concatenate
> a str with type.
> In principle one could have lots of objections to that code. Why only log on
> debug level debug, when there was an unexpected error? The english in the
> error message doesn't really parse.
> Personally I would prefer removing it altogether. If we want to log all
> exceptions via the logging framework instead of leaving that responsibility
> to the caller a generic catch all in the last block of the file that logs
> everything that no one else catches properly would be a better option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
