[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306914#comment-14306914
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8215:
--------------------------------------------

GitHub user terbolous opened a pull request:

    https://github.com/apache/cloudstack/pull/71

    CLOUDSTACK-8215: SAML changing date calculation

    Changed to java.util.Calendar which is a bit more straight forward to use.
    
    Tested and verified that the new certificate is valid for 3 years

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/terbolous/cloudstack saml2-certvalidity

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit b84c8889a35a8e56969d0f27f22cf197576f0728
Author: Erik Weber <[email protected]>
Date:   2015-02-05T08:54:49Z

    SAML changing date calculation
    
    Signed-off-by: Erik Weber <[email protected]>

----


> SAML2 authentication provider certificate is only valid for two days
> --------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8215
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8215
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Management Server
>    Affects Versions: 4.5.0, 4.6.0
>         Environment: Fresh 4.5 running on CentOS 6. Built from lastest sha 
> (5159cbec9f7 at time of wring)
>            Reporter: Erik Weber
>              Labels: easyfix
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There's something wrong with the date calculation in 
> SAMLUtils.generateRandomX509Certificate().
> The result is that the certificate is only valid for ~2 days, while it 
> probably should be valid for much longer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to