[
https://issues.apache.org/jira/browse/CLOUDSTACK-8279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340764#comment-14340764
]
ASF GitHub Bot commented on CLOUDSTACK-8279:
--------------------------------------------
GitHub user K0zka opened a pull request:
https://github.com/apache/cloudstack/pull/90
Cloudstack 8279
Fixes for
[CLOUDSTACK-8279](https://issues.apache.org/jira/browse/CLOUDSTACK-8279) and
two minor cleanups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/K0zka/cloudstack CLOUDSTACK-8279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 5626a340dd271ec585f973dfa99a2a7fb45abac3
Author: Laszlo Hornyak <[email protected]>
Date: 2015-02-25T19:55:56Z
Logical expression simplification, == true is redundant
Signed-off-by: Laszlo Hornyak <[email protected]>
commit e6e3a20bd6ef95d40af2018c74430a0b5f77166b
Author: Laszlo Hornyak <[email protected]>
Date: 2015-02-25T19:58:25Z
removed redundant autoboxing
Signed-off-by: Laszlo Hornyak <[email protected]>
commit f8c003d13a4b26839712d8534f8b89fa00dc1275
Author: Laszlo Hornyak <[email protected]>
Date: 2015-02-27T18:03:08Z
CLOUDSTACK-8279: test fix for java 1.8
The test build on an assumption on the order of items in a Set, while this
changed in java 1.8
Signed-off-by: Laszlo Hornyak <[email protected]>
commit df11bb28110d49b5a46790c351a3f309b5c6569e
Author: Laszlo Hornyak <[email protected]>
Date: 2015-02-27T19:06:27Z
CLOUDSTACK-8279: Fix unit test for java 1.8
Signed-off-by: Laszlo Hornyak <[email protected]>
----
> unit test errors with openjdk 1.8
> ---------------------------------
>
> Key: CLOUDSTACK-8279
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8279
> Project: CloudStack
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, Test
> Affects Versions: 4.6.0
> Environment: fedora 21
> openjdk 1.8
> Reporter: Laszlo Hornyak
> Attachments:
> TEST-com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest.xml,
> com.cloud.agent.resource.virtualnetwork.VirtualRoutingResourceTest.txt
>
>
> When using the default OpenJDK 1.8 shipping with fedora 21, The following
> unit tests break the build:
> * VirtualRoutingResourceTest.testAggregationCommands
> * VirtualRoutingResourceTest.testFirewallRulesCommand
> After installing Oracle JDK 1.7, the tests pass.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
