[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530195#comment-14530195
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8394:
--------------------------------------------

GitHub user gauravaradhye opened a pull request:

    https://github.com/apache/cloudstack/pull/231

    CLOUDSTACK-8394: Skip test cases through setUp() instead of setUpClass()

    Doing the changes for regression test cases. This has already been done for 
BVTs.
    Reason: When raise "unittest.SkipTest()" is used in setUpClass, it is 
reported as exception. Instead skip the test cases through setUpClass to get 
correct results.
    
    Other changes:
    1. Fixed pep8 issues
    2. Fixed import issues

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gauravaradhye/cloudstack 8394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit e971ad0b1d3497f72dc27cfc4510f896ac226459
Author: Gaurav Aradhye <[email protected]>
Date:   2015-04-30T02:14:21Z

    CLOUDSTACK-8394: Skipping snapshots test cases for HyperV and LXC

commit 65f3e38595755e1785f3c5d187bbba83febf1fba
Author: Gaurav Aradhye <[email protected]>
Date:   2015-05-06T09:05:39Z

    CLOUDSTACK-8394: Skip test cases through setUp() instead of setUpClass()

----


> Skip test cases through setUp() instead of setUpClass()
> -------------------------------------------------------
>
>                 Key: CLOUDSTACK-8394
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8394
>             Project: CloudStack
>          Issue Type: Test
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Automation
>    Affects Versions: Future
>            Reporter: Gaurav Aradhye
>            Assignee: Gaurav Aradhye
>              Labels: automation
>             Fix For: Future
>
>
> When the tests are skipped through setUpClass, the statement "raise 
> unittest.SkipTest()" is used. This is seen as exception in the logs. To avoid 
> this, alternatively we can set class level variable in setUpClass and read 
> this variable value in setUp() and skip the test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to