[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572921#comment-14572921
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8537:
--------------------------------------------

GitHub user DaanHoogland opened a pull request:

    https://github.com/apache/cloudstack/pull/357

    CLOUDSTACK-8537 add check for unique public key on registration

    tests are following but need a manager refactor:(

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-8537

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #357
    
----
commit 94e0499b66c225350cd554116dad57bd68f2a4bc
Author: Daan Hoogland <[email protected]>
Date:   2015-06-04T14:48:14Z

    CLODSTACK-8537 add check for unique public key on registration

----


> Duplicated SSH Keys/ deployVirtualMachine returns wrong keypair name
> --------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8537
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8537
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.3.0
>            Reporter: Benjamin vickers
>            Assignee: Daan Hoogland
>
> Steps:
> 1. Register 2 SSH keypairs sequentially in the same account, both with 
> identical public key text, and with names "keypair1" and "keypair2"
> 2. Send deployVirtualMachine request, with the keypair parameter set to 
> "keypair2"
> 3. deployVirtualMachine response sends back value "keypair1"
> I am using this with the Terraform (IaC) project and this behaviour breaks 
> convergence. I would expect that either
> (i) duplicate copies of the same SSH key are not allowed to be registered
> (ii) instance must send back the same key pair name as was requested



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to