[
https://issues.apache.org/jira/browse/CLOUDSTACK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629258#comment-14629258
]
ASF GitHub Bot commented on CLOUDSTACK-8639:
--------------------------------------------
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/595#issuecomment-121843873
I browsed the code and found out that this "templateSize =
int(int(templates[0].size) / (1024**3))" was already been used in other places.
So, your changes does make sense to me and therefore you get a LGTM :+1:
Cheers,
Wilder
> fixing calculation mistakes in component/test_ss_domain_limits.py
> -----------------------------------------------------------------
>
> Key: CLOUDSTACK-8639
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8639
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: marvin
> Affects Versions: 4.5.1
> Reporter: prashant kumar mishra
> Assignee: prashant kumar mishra
> Fix For: 4.5.1
>
>
> expectedCount=int(int(templates[0].size) / (1024**3))
> expectedCount *= 2
> if template[0].size is less that one GB , expectedCount will be 0
> so expectedCount*=2 will not have any effect .
> fixing expectedCount calculation:
> self.templateSize = int((int(templates[0].size)*2) / (1024**3))
> expectedCount =self.templateSize
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
