[
https://issues.apache.org/jira/browse/CLOUDSTACK-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629461#comment-14629461
]
ASF GitHub Bot commented on CLOUDSTACK-8415:
--------------------------------------------
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/540#discussion_r34767845
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -172,7 +175,11 @@ public DataObject create(DataObject obj, DataStore
dataStore) {
if (snapshotDataStoreVO != null) {
ss.setParentSnapshotId(snapshotDataStoreVO.getSnapshotId());
}
-
ss.setInstallPath(TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" +
snapshot.getVolumeId());
+ String snapshotInstallPath =
TemplateConstants.DEFAULT_SNAPSHOT_ROOT_DIR + "/" +
snapshotDao.findById(obj.getId()).getAccountId() + "/" + snapshot.getVolumeId();
+ if
(snapshot.getHypervisorType().equals(HypervisorType.VMware)) {
+ snapshotInstallPath =
snapshotInstallPath.concat("/" + UUID.randomUUID().toString());
--- End diff --
I would also call contact twice: 1 for the "/"; and the 2nd time for the
UUID.randomUUID().toString().
> [VMware] SSVM shutdown during snapshot operation results in disks to be left
> behind
> ------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8415
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8415
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Likitha Shetty
> Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> Partial disks are residue of a failed snapshot operation caused by SSVM
> reboot/shutdown. The disks do not get cleaned up on secondary storage and
> need to be cleaned up manually to release storage.
> +Steps to reproduce+
> 1. Initiate a volume snapshot operation.
> 2. Destroy SSVM while the operation is in progress.
> 3. Check the snapshot folder in secondary storage - Files including disks are
> present in the folder and are never cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
