[
https://issues.apache.org/jira/browse/CLOUDSTACK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652064#comment-14652064
]
ASF GitHub Bot commented on CLOUDSTACK-8703:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/651#discussion_r36102628
--- Diff: utils/src/com/cloud/utils/S3Utils.java ---
@@ -352,10 +352,15 @@ public static File getFile(final ClientOptions
clientOptions, final String bucke
ListObjectsRequest listObjectsRequest = new
ListObjectsRequest().withBucketName(bucketName).withPrefix(directory +
SEPARATOR);
ObjectListing ol = client.listObjects(listObjectsRequest);
- while (ol != null && ol.isTruncated()) {
+ if(ol.isTruncated()) {
--- End diff --
is ol guaranteed not to be null? I don't see any specific remark on this in
the amazon javadoc.
> Cloudstack tries to re-download templates on S3 while they are already their.
> -----------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8703
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8703
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Secondary Storage
> Affects Versions: 4.5.2
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
> Fix For: 4.6.0, 4.5.2
>
>
> When the management server restarts, reason doesn't matter, it will try to
> list all of the available templates on the secondary storage. To redownload
> them when they are missing. On S3, S3Utils listDirectory() will not return
> these because of a bug introduced in the following commit:
> debcbcc1454789936407583fe0aba8e158b16cad. So the management server will
> redownload them all. The listDirectory() method in S3Utils.java will only
> return objects when the anwser it receives from the S3 system is truncated.
> So listing smaller then the pagination limit will always return 0 obejcts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
