[
https://issues.apache.org/jira/browse/CLOUDSTACK-8716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679546#comment-14679546
]
ASF GitHub Bot commented on CLOUDSTACK-8716:
--------------------------------------------
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36601402
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+ validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+ get_zone,
+ list_volumes,
+ list_clusters,
+ get_template
+ )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ testClient = super(TestMultipleVolumeSnapshots,
cls).getClsTestClient()
+ cls.apiclient = testClient.getApiClient()
+ cls.testdata = testClient.getParsedTestDataConfig()
+
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.apiclient)
+ cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+ cls.hypervisor = cls.testClient.getHypervisorInfo()
+ cls.template = get_template(
+ cls.apiclient,
+ cls.zone.id,
+ cls.testdata["ostype"])
+
+ cls._cleanup = []
+
+ cls.skiptest = False
+
+ clus_list = list_clusters(cls.apiclient)
+
+ if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+ cls.skiptest = True
+ return
+
+ try:
+ # Create an account
+ cls.account = Account.create(
+ cls.apiclient,
+ cls.testdata["account"],
+ domainid=cls.domain.id
+ )
+
+ # Create user api client of the account
+ cls.userapiclient = testClient.getUserApiClient(
+ UserName=cls.account.name,
+ DomainName=cls.account.domain
+ )
+ # Create Service offering
+ cls.service_offering_zwps = ServiceOffering.create(
+ cls.apiclient,
+ cls.testdata["service_offering"],
+ tags=ZONETAG1
+ )
+
+ cls.disk_offering_zwps = DiskOffering.create(
+ cls.apiclient,
+ cls.testdata["disk_offering"],
+ tags=ZONETAG1
+ )
+
+ cls._cleanup = [
+ cls.account,
+ cls.service_offering_zwps,
+ cls.disk_offering_zwps,
+ ]
+ except Exception as e:
+ cls.tearDownClass()
+ raise e
+ return
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.apiclient, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+
+ def setUp(self):
+
+ self.cleanup = []
+ if self.skiptest:
+ self.skipTest("Skip test as setup is either not VMWare or \
+ having less than 2 clusters %s" % self.hypervisor)
+
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.pools = []
+
+ def tearDown(self):
+ try:
+ for storagePool in self.pools:
+ StoragePool.update(self.apiclient, id=storagePool.id,
tags="")
+
+ cleanup_resources(self.apiclient, self.cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ @attr(tags=["advanced", "basic"], required_hardware="true")
+ def test_01_multiple_snapshot_in_zwps(self):
+ """ Test multiple volume snapshot in zwps
+
+ # 1. Verify if setup has a ZWPS and 2 CWPS
+ # 2. Deploy a VM with data disk in ZWPS
+ # 1. Verify ROOT and DATA Disk of the VM is in ZWPS.
+ # 2. Take a snapshot of VM.
+ # 3. Create Multiple Snapshots till operation fails.
+ """
+ try:
+ if (self.clus_list) < 2:
+ self.skipTest(
+ "There must be at least two clusters in the setup")
+
+ self.pools = StoragePool.list(self.apiclient,
zoneid=self.zone.id)
--- End diff --
We are skipping the test here if the self.clus_list < 2. In that case
self.pools will not have any value. However, we are referring it in teatDown
method. I think test will fail in that case.
We are already validating the no.of clusters in setUpClass method. So why
do we need this here?
> Verify creation of snapshot from volume when the task is performed repeatedly
> in zone wide primary Storage.
> -----------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8716
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8716
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Automation
> Affects Versions: 4.2.1
> Reporter: Priti Sarap
> Fix For: 4.2.1
>
>
> On VMWare with a Zone wide primary storage and more than two clusters verify
> successful creation of snapshot multiple times.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
