[
https://issues.apache.org/jira/browse/CLOUDSTACK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699290#comment-14699290
]
ASF GitHub Bot commented on CLOUDSTACK-8737:
--------------------------------------------
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/701#issuecomment-131756869
LGTM. one note of worry though. removing the configuration item is arguably
a backwards incompatible change to the interface. I don't object to it, as
stated by the first acronym used in this message.
> Remove out-of-band VR reboot code based on persistent VR configuration changes
> ------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8737
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8737
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Fix For: 4.6.0
>
>
> VR reboot was required to reprogram rules in case it was stopped and started
> outside of CS. With persistent VR configuration changes (added in 4.6) the
> rules are persisted across a stop-start of VR. So no need to do VR reboot.
> Refer to the following discussion on dev list.
> http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201506.mbox/%[email protected]%3e
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
