[
https://issues.apache.org/jira/browse/CLOUDSTACK-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713039#comment-14713039
]
ASF GitHub Bot commented on CLOUDSTACK-8758:
--------------------------------------------
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/737#discussion_r37976062
--- Diff: pom.xml ---
@@ -1,12 +1,23 @@
-<!-- Licensed to the Apache Software Foundation (ASF) under one or more
contributor
- license agreements. See the NOTICE file distributed with this work for
additional
- information regarding copyright ownership. The ASF licenses this file to
you under
- the Apache License, Version 2.0 (the "License"); you may not use this
file except
- in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
- Unless required by applicable law or agreed to in writing, software
distributed under
- the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS
- OF ANY KIND, either express or implied. See the License for the specific
language
- governing permissions and limitations under the License. -->
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
--- End diff --
@pdion891 good fix. I would very much more rather relying on the xml tag
than a line number.
Before the change I got the mycila license plugin complaining during `mvn
clean install`, so I changed the header to make it happy. Then the rats build
was also complaining, and I made more changes to make that one happy.
I wonder how was it that before this change, neither the mycila plugin or
the rats build complained?
> Handle redirects in communication with NXS controller (a.k.a. Nicira NVP)
> -------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8758
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8758
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Devices
> Reporter: Miguel Ferreira
> Priority: Minor
> Fix For: 4.6.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> When setup in a cluster, NSX controllers will redirect calls to the cluster
> master. However, the NiciraNvp plugin does not handle those redirects
> correctly. The underlying HTTP client will transparently redirect calls, but
> the plugin will aways override the target host to the initial value.
> The underlying HTTP library being used at the moment is Apache HTTP Commons,
> which has been superseded by Apache HTTP Components which introduces a new
> architecture. This library should be upgraded to the new architecture since
> this will make it easier to transparently handle redirects,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
