[
https://issues.apache.org/jira/browse/CLOUDSTACK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725179#comment-14725179
]
ASF GitHub Bot commented on CLOUDSTACK-8785:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/760#discussion_r38406769
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -383,10 +383,10 @@ public void scheduleRestart(VMInstanceVO vm, boolean
investigate) {
}
List<HaWorkVO> items = _haDao.findPreviousHA(vm.getId());
- int maxRetries = 0;
+ int timesTried = 0;
--- End diff --
I like the rename!
> Proper enforcement of retry count (max.retries) for all work type handled by
> HighAvailability manager
> -----------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8785
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8785
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Koushik Das
> Assignee: Koushik Das
> Fix For: 4.6.0
>
>
> There is inconsistency in the way max. retry limit is applied for the
> different work types handled by HA manager. The default retry limit is 5, so
> any work should not be retried more than 5 times.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
