[
https://issues.apache.org/jira/browse/CLOUDSTACK-8797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730417#comment-14730417
]
ASF GitHub Bot commented on CLOUDSTACK-8797:
--------------------------------------------
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726691
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
closeContext(context);
}
}
+
+ @Override
+ public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String
type, String name, short accountType) {
+ Validate.notNull(type, "type cannot be null. It should either be
GROUP or OU");
+ Validate.notNull(domainId, "domainId cannot be null.");
+ Validate.notEmpty(name, "GROUP or OU name cannot be empty");
--- End diff --
Issue of multiple CS domains mapping to same ldap group is tracked as part
of CLOUDSTACK-8797. For now changes look fine.
> a single ldap group/ou can be mapped to multiple domain in cloudstack
> ---------------------------------------------------------------------
>
> Key: CLOUDSTACK-8797
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8797
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rajani Karuturi
>
> since the username is unique only within a domain in cloudstack, a member of
> ldap group/ou can be part of two or more cloudstack domains with different
> accounts
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
