[
https://issues.apache.org/jira/browse/CLOUDSTACK-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734390#comment-14734390
]
ASF GitHub Bot commented on CLOUDSTACK-8799:
--------------------------------------------
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r38897976
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -261,20 +261,9 @@ def set_master(self):
self.set_lock()
logging.debug("Setting router to master")
- ads = [o for o in self.address.get_ips() if o.is_public()]
- dev = ''
- for o in ads:
- if dev == o.get_device():
- continue
- cmd2 = "ip link set %s up" % o.get_device()
- if CsDevice(o.get_device(), self.config).waitfordevice():
- CsHelper.execute(cmd2)
- dev = o.get_device()
- logging.info("Bringing public interface %s up" %
- o.get_device())
- else:
- logging.error(
- "Device %s was not ready could not bring it up" %
o.get_device())
+ self.address.process()
+ logging.info("added default rotue")
--- End diff --
There is a typo here. Could you fix that?
Also, the logging could be more verbose. To what is the default route
pointing? We should log that as well.
> fix CsRedundant.py to handle public interfaces and default routes when
> changing state.
> --------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8799
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8799
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Virtual Router
> Affects Versions: 4.6.0
> Reporter: Bharat Kumar
> Assignee: Bharat Kumar
> Priority: Critical
>
> When the Vr changes state to backup we need bring all the public interfaces
> down. Similarly when it changes state to master we have bring all the public
> interfaces up and add the default routes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
