[
https://issues.apache.org/jira/browse/CLOUDSTACK-8815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738839#comment-14738839
]
ASF GitHub Bot commented on CLOUDSTACK-8815:
--------------------------------------------
GitHub user sudhansu7 opened a pull request:
https://github.com/apache/cloudstack/pull/799
CLOUDSTACK-8815 : Issues with cloudstack-management init script
When a management server is halted or rebooted, the cloudstack-management
init script does not successfully kill the associated java process. There will
always be an error about "Cannot find PID file". The script should be reworked
so that there are no errors and java is killed correctly.
This appears to be due to the script using the basename of the script:
NAME="$(basename $0)"
To look for the pid file:
if [ -f /var/run/$
{NAME}
.pid ]; then
This does work correctly if the script is run directly (basename will be
"cloudstack-management", so "cloudstack-management.pid" file is found). However
when a server is halted or rebooted, the script is not run directly but via the
symlinks in /etc/rc.d/rc0.d/ and /etc/rc.d/rc0.d/, respectively. The symlinks
are named "K20cloudstack-management" so the script looks for a pid file named
"K20cloudstack-management.pid" which does not exist.
screenshots:
Before fix:
After fix:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudhansu7/cloudstack CLOUDSTACK-8815
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #799
----
commit 45ebfb0d2f81a55c0f9ab89abfd0cb1de0c7b57c
Author: Sudhansu <[email protected]>
Date: 2015-09-10T14:29:51Z
CLOUDSTACK-8815 : Issues with cloudstack-management init script
instead of using basename use target file.
----
> Issues with cloudstack-management init script
> ---------------------------------------------
>
> Key: CLOUDSTACK-8815
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8815
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Install and Setup
> Reporter: Sudhansu Sahu
> Assignee: Sudhansu Sahu
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> When a management server is halted or rebooted, the cloudstack-management
> init script does not successfully kill the associated java process. There
> will always be an error about "Cannot find PID file". The script should be
> reworked so that there are no errors and java is killed correctly.
> This appears to be due to the script using the basename of the script:
> NAME="$(basename $0)"
> To look for the pid file:
> if [ -f /var/run/$
> {NAME}
> .pid ]; then
> This does work correctly if the script is run directly (basename will be
> "cloudstack-management", so "cloudstack-management.pid" file is found).
> However when a server is halted or rebooted, the script is not run directly
> but via the symlinks in /etc/rc.d/rc0.d/ and /etc/rc.d/rc0.d/, respectively.
> The symlinks are named "K20cloudstack-management" so the script looks for a
> pid file named "K20cloudstack-management.pid" which does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
