[
https://issues.apache.org/jira/browse/CLOUDSTACK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740517#comment-14740517
]
ASF GitHub Bot commented on CLOUDSTACK-8822:
--------------------------------------------
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/805
CLOUDSTACK-8822 - Replacing Runnable by Callable
That's the first part of the refactor, which will touch the
ManagedContextRunnable and all its subclasses. However, in order to reduce
impact, the first part comprises the Agent and Nio related classes
(NioConnection, NioServer and NioClient).
* All the sub-classes were also updated according to the changes in the
super-classes
* Improved exception handling
* There were also code formatting changes
Changes were structural and the NioTest covered them without need to modify
the unit test.
This PR is quite extensive. Please, wait for the Test Report in order to
proceed with further review.
ping @remibergsma @miguelaferreira @bhaisaab @karuturi @wido @DaanHoogland
@borisroman @K0zka
Cheers,
Wilder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ekholabs/cloudstack
improvement/callable_CLOUDSTACK-8822
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/805.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #805
----
commit 79a3f8c5774c50dc128968c29da5096dc3dde39e
Author: wilderrodrigues <[email protected]>
Date: 2015-09-08T10:12:55Z
CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and
NioConnection classes
- All the sub-classes were also updated according to the changes in the
super-classes
- There were also code formatting changes
----
> Replace Runnable by Callable in the com.cloud.utils.nio.Task class.
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-8822
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8822
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>
> The current implementation of the Task abstract class swallows all the
> exceptions - everything extending Throwable - with only a WARN message.
> The best way to do that is by implementing Callable, which returns a value
> and also has a "throws Exception" in the call(0 method signature.
> This work will be structural, changing the hierarchy of Task and also its
> subclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
