[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740629#comment-14740629
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8798:
--------------------------------------------

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/800#discussion_r39263080
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDatabag.py ---
    @@ -130,7 +136,10 @@ def get_router_password(self):
             This is slightly difficult to happen, but if it does, destroy the 
router with the password generated with the
             code below and restart the VPC with out the clean up option.
             '''
    -        passwd = "%s-%s" % (self.get_vpccidr, self.get_router_id())
    +        if(self.get_type()=='router'):
    --- End diff --
    
    - run pep8, fix errors
    - consider using -- if self.get_type() == "router"   or   if 
self.get_type() is "router"
    - stick to uniform usage to quotes, double quotes for strings here so 
"router" instead of 'router'


> fix the keepalived configuration in rvr.
> ----------------------------------------
>
>                 Key: CLOUDSTACK-8798
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8798
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: Virtual Router
>    Affects Versions: 4.6.0
>            Reporter: Bharat Kumar
>            Assignee: Bharat Kumar
>            Priority: Blocker
>
> currently in the keepalived.confg the virtual ip addresses that is configured 
> is incorrect it has to be the gateway ip of the corresponding guest network. 
> Also the auth password generated is different for each of the rvr. The auth 
> password need to be same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to