[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742600#comment-14742600
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8625:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/813#issuecomment-139907185
  
    @wido In order to get it to work on CentOS 7 I had to patch it like this. 
You may want to add it to the PR:
    
    ```
    diff --git a/packaging/centos7/cloud.spec b/packaging/centos7/cloud.spec
    index 0ecc406..2028981 100644
    --- a/packaging/centos7/cloud.spec
    +++ b/packaging/centos7/cloud.spec
    @@ -488,7 +488,8 @@ fi
     %attr(0755,root,root) %{_bindir}/%{name}-setup-agent
     %attr(0755,root,root) %{_bindir}/%{name}-agent-upgrade
     %attr(0755,root,root) %{_bindir}/%{name}-ssh
    -%attr(0755,root,root) %{_sysconfdir}/init.d/%{name}-agent
    +%attr(0644,root,root) %{_unitdir}/%{name}-agent.service
    +%attr(0755,root,root) 
/usr/libexec/cloudstack/cloudstack-agent-systemd-wrapper.sh
     %attr(0644,root,root) %{_sysconfdir}/profile.d/%{name}-agent-profile.sh
     %attr(0755,root,root) %{_datadir}/%{name}-common/scripts/network/cisco
     %config(noreplace) %{_sysconfdir}/%{name}/agent
    ```
    
    Tested it on CentOS 7.1 KVM box and the `systemd` profile works great! If 
you update the PR with the above patch (or something with the same result) I'll 
give you my LGTM :-)
    
    Thanks, Remi


> Systemd profile for KVM Agent
> -----------------------------
>
>                 Key: CLOUDSTACK-8625
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8625
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: KVM
>         Environment: Ubuntu 16.04, CentOS 7.X
>            Reporter: Wido den Hollander
>              Labels: agent, kvm, systemd
>             Fix For: Future
>
>
> We currently only support sysvinit, but with CentOS and Ubuntu both moving to 
> Systemd we should support systemd.
> To do this we can:
> - Loose JSVC
> - Log to stdout and let systemd / journalctl handling the logging



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to