[
https://issues.apache.org/jira/browse/CLOUDSTACK-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14802809#comment-14802809
]
ASF GitHub Bot commented on CLOUDSTACK-8805:
--------------------------------------------
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141056052
in general: factor out a small chunk of the method into a private method or
helper class. (commit 1)
then unit test that. (commit 2)
then apply your fix (commit three) bull's eye (hopefully)
In your more particular case @nitin-maharana , I think we don't have the
test infrastructure to do it.
We need to create it. I am not burdonning you with this but if you want to:
the replace call you make is in the sql domain and what we'd need is sql unit
stuff.
I am starting to feel my wearyness is ungrounded but those feeling are
always dangerous. A replacement of the replace call in java space could make it
more (read easier) testable. it might have performance ramifications.
that all said; let's discus risk versus priority of this fix. Does anybody
have ideas on this?
> Domains become inactive automatically.
> --------------------------------------
>
> Key: CLOUDSTACK-8805
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8805
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Nitin Kumar Maharana
>
> If there is a domain with name '%', if we force delete the '%' domain then
> all the other domains become inactive except Root domain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
