[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803354#comment-14803354
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8763:
--------------------------------------------

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/845#issuecomment-141175510
  
    @wilderrodrigues The steps to test this are simply creating a POD, then 
deleting it. It fails in current master and succeeds in this PR. Same with a 
zone. If you deploy with Marvin and make sure it cannot find the hypervisor, 
the cleanup should succeed. That doesn't work either on current master as it 
leaves you with a half cleaned-up mess preventing you from deploying again.
    
    I showed the manual tests above (screenshots). Here's the failing Marvin 
deploy with successful cleanup. I made sure the hypervisor was down so it 
couldn't succeed.
    
    ```
    [root@cs1 cloudstack]# python 
/data/git/$HOSTNAME/cloudstack/tools/marvin/marvin/deployDataCenter.py -i 
/data/shared/marvin/mct-zone2-xen2.cfg
    
    ==== Log Folder Path: 
/tmp//MarvinLogs//DeployDataCenter__Sep_17_2015_18_20_59_Z1US54. All logs will 
be available here ====
    
    ==== Deploy DC Started ====
    Exception Occurred :['Traceback (most recent call last):\n', '  File 
"/data/git/cs1/cloudstack/tools/marvin/marvin/deployDataCenter.py", line 136, 
in addHosts\n    ret = self.__apiClient.addHost(hostcmd)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 1572, in addHost\n    response = self.connection.marvinRequest(command, 
response_type=response, method=method)\n', '  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in 
marvinRequest\n    raise e\n', 'CloudstackAPIException: Execute cmd: addhost 
failed, due to: errorCode: 530, errorText:Unable to add the host\n']
    
    ===deploy dc failed, so cleaning the created entries===
    
    ====DeployDC: CleanUp Started====
    
    ====Clean Up Entries=== {'PhysicalNetwork': 
[u'd69f38fc-6fa9-474d-a89a-b8d8a7219cf4'], 'Cluster': 
[u'1a51747a-fc04-4a57-9b4f-5b1b3dcaa3ba'], 'Pod': 
[u'73132578-a301-4e89-8397-df043568efa7'], 'order': ['Cluster', 'Pod', 
'PhysicalNetwork', 'Zone'], 'Zone': [u'406ec1f9-1c90-46a1-9a3a-ee137f5baf7b']}
    
    ===Removing DataCenter Successful===
    ```


> Deleting a POD/Zone always fails due to a SQLException
> ------------------------------------------------------
>
>                 Key: CLOUDSTACK-8763
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8763
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>    Affects Versions: 4.6.0
>            Reporter: Remi Bergsma
>            Assignee: Boris Schrijver
>            Priority: Blocker
>
> The Management Server failed to detect if pod is deletable. Please contact 
> Cloud Support.
> This also means Marvin cannot clean up after a test.
> 2015-08-21 10:07:10,822 DEBUG [c.c.a.ApiServlet] 
> (1226927357@qtp-701028225-5:ctx-0000a82e) ===START===  192.168.22.240 -- GET  
> command=deletePod&id=358df0b2-0bc0-480b-81a8-0675c59a808e&response=json&_=1440151630775
> 2015-08-21 10:07:10,826 ERROR [c.c.a.ApiServer] 
> (1226927357@qtp-701028225-5:ctx-0000a82e ctx-1c95970d) unhandled exception 
> executing api command: [Ljava.lang.String;@3cc57321
> com.cloud.utils.exception.CloudRuntimeException: The Management Server failed 
> to detect if pod is deletable. Please contact Cloud Support.
>         at 
> com.cloud.configuration.ConfigurationManagerImpl.checkIfPodIsDeletable(ConfigurationManagerImpl.java:954)
>         at 
> com.cloud.configuration.ConfigurationManagerImpl.deletePod(ConfigurationManagerImpl.java:1032)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:606)
>         at 
> org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
>         at 
> org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91)
>         at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
>         at 
> org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
>         at com.sun.proxy.$Proxy110.deletePod(Unknown Source)
>         at 
> org.apache.cloudstack.api.command.admin.pod.DeletePodCmd.execute(DeletePodCmd.java:70)
>         at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:141)
>         at com.cloud.api.ApiServer.queueCommand(ApiServer.java:704)
>         at com.cloud.api.ApiServer.handleRequest(ApiServer.java:529)
>         at 
> com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:296)
>         at com.cloud.api.ApiServlet$1.run(ApiServlet.java:127)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
>         at 
> org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
>         at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:124)
>         at com.cloud.api.ApiServlet.doGet(ApiServlet.java:86)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
>         at 
> org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
>         at 
> org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:401)
>         at 
> org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
>         at 
> org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
>         at 
> org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
>         at 
> org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
>         at 
> org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
>         at 
> org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:114)
>         at 
> org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
>         at org.mortbay.jetty.Server.handle(Server.java:326)
>         at 
> org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
>         at 
> org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:928)
>         at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:549)
>         at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212)
>         at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
>         at 
> org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
>         at 
> org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> 2015-08-21 10:07:10,827 DEBUG [c.c.a.ApiServlet] 
> (1226927357@qtp-701028225-5:ctx-0000a82e ctx-1c95970d) ===END===  
> 192.168.22.240 -- GET  
> command=deletePod&id=358df0b2-0bc0-480b-81a8-0675c59a808e&response=json&_=1440151630775
> 2015-08-21 10:07:11,540 INFO  [o.a.c.f.j.i.AsyncJobManagerImpl] 
> (AsyncJobMgr-Heartbeat-1:ctx-37b4fb95) Begin cleanup expired async-jobs
> Same for deleting a zone:
> (local) � > delete zone id=47b7f0d0-7018-419a-8e44-99ed022f0de4
> Error 530: The Management Server failed to detect if zone is deletable. 
> Please contact Cloud Support.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to