[
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805302#comment-14805302
]
ASF GitHub Bot commented on CLOUDSTACK-8816:
--------------------------------------------
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/849
Cloudstack-8816 some of the events do not have resource uuids
The key objects in the context map are sometimes String and sometimes
object. This causes missing uuids when an entity put in the context map with
key entity.toString is queried with key entity
Testing:
manually tested by deploying a vm and checked that the created events in
rabbitmq now has uuids.
events before and after the change are update at
https://issues.apache.org/jira/browse/CLOUDSTACK-8816?focusedCommentId=14805239
unittests
```
$ mvn -pl :cloud-api test -Dtest=CallContextTest
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.cloudstack.context.CallContextTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec -
in org.apache.cloudstack.context.CallContextTest
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 11.445 s
[INFO] Finished at: 2015-09-18T14:58:53+05:30
[INFO] Final Memory: 55M/448M
[INFO]
------------------------------------------------------------------------
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8816-take2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/849.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #849
----
commit fbdcd04a1950b2374a25993aef324fe52527909c
Author: Rajani Karuturi <[email protected]>
Date: 2015-09-18T09:23:11Z
CLOUDSTACK-8816: some of the events do not have resource uuids
the key for an entity is sometimes an object a String with value
object.toString() due to serialization and deserialization of them.
Addressed this in the getter of CallContext to check for key.toString
if an object is not found with key.
commit 2b6a0b363c0518f9571dd1ff092784f3fde92a95
Author: Rajani Karuturi <[email protected]>
Date: 2015-09-18T09:26:02Z
CLOUDSTACK-8816: some of the events do not have resource uuids
uuid is missing in the first event of VM create as the entity is just
created and never put in the Context.
Added the entity uuid to context on successful creation.
----
> rabbitMQ: generated events have wrong or missing uuids
> ------------------------------------------------------
>
> Key: CLOUDSTACK-8816
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8816
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Affects Versions: 4.3.2, 4.4.4, 4.5.2
> Reporter: Rajani Karuturi
> Assignee: Rajani Karuturi
> Priority: Critical
>
> For many events, entity uuids are missing. One such example is below.
> (updated in the comments with events before and after the changes)
> 1. create an account ppp
> 2,create few users under ppp account
> 3.delete the "ppp" account
> 4.check the rabbit mq for generated events
> actual result:
> Therecieved event has admin user uuid instead of deleted account uuid
> The server reported 0 messages remaining.
> Exchange cloudstack-events
> Routing Key management-server.AsyncJobEvent.complete.Account.*
> Redelivered ●
> Properties
> priority: 0
> delivery_mode: 2
> content_type: text/plain
> Payload 885 bytes Encoding: string
> {"cmdInfo":"{\"id\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"response\":\"json\",\"sessionkey\":\"bYp8fdaTPgTYLtuVlSPxnHj9Iuk\\u003d\",\"ctxDetails\":\"{\\\"com.cloud.user.Account\\\":\\\"d08d73a5-b577-4082-a959-114b433979f1\\\"}\",\"cmdEventType\":\"ACCOUNT.DELETE\",\"ctxUserId\":\"2\",\"httpmethod\":\"GET\",\"_\":\"1416046428981\",\"uuid\":\"d08d73a5-b577-4082-a959-114b433979f1\",\"ctxAccountId\":\"2\",\"ctxStartEventId\":\"271\"}","instanceType":"Account","instanceUuid":"","jobId":"0749f13f-517b-4cba-81f2-c9a9d23445cd","status":"SUCCEEDED","processStatus":"0","commandEventType":"ACCOUNT.DELETE","resultCode":"0","command":"org.apache.cloudstack.api.command.admin.account.DeleteAccountCmd","jobResult":"org.apache.cloudstack.api.response.SuccessResponse/null/{\"success\":true}","account":"fcf6dd7e-6983-11e4-bb12-0662940000db","user":"fcf71ae6-6983-11e4-bb12-0662940000db"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
